Skip to content

doc: show conventional commits instructions #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2022
Merged

doc: show conventional commits instructions #504

merged 2 commits into from
Mar 30, 2022

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Mar 28, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #367 🦕

@tswast tswast requested a review from a team as a code owner March 28, 2022 22:01
@tswast tswast requested review from a team and shollyman March 28, 2022 22:01
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Mar 28, 2022
@tswast
Copy link
Collaborator Author

tswast commented Mar 28, 2022

Looks like we need to omit .nox directories from linting.

@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Mar 30, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit d0999e6 into main Mar 30, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the issue367-conventional-commits branch March 30, 2022 20:22
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tswast @shollyman